Skip to content

Variations: Refactor how we access all variations. #8560

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 6, 2023
Merged

Variations: Refactor how we access all variations. #8560

merged 1 commit into from
Jan 6, 2023

Conversation

@Ecarrion
Copy link
Contributor

@Ecarrion Ecarrion commented Jan 5, 2023

Why

This PR does a small pending refactor to not access fetched variations via ServiceLocator.storageManager but instead do it via the synchronizeAllProductVariations action.

How

  • Update ProductsVariationAction.synchronizeAllProductVariations to return the fetched variations on it's completion block

Testing

  • See that generating variations keeps working as the last PR.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@Ecarrion Ecarrion added the feature: variation list Related to the variations list for variable products. label Jan 5, 2023
@Ecarrion Ecarrion added this to the 11.8 milestone Jan 5, 2023
@Ecarrion Ecarrion requested a review from ealeksandrov January 5, 2023 14:13
@peril-woocommerce
Copy link

peril-woocommerce bot commented Jan 5, 2023

Warnings
⚠️ This PR is assigned to a milestone which is closing in less than 2 days Please, make sure to get it merged by then or assign it to a later expiring milestone

Generated by 🚫 dangerJS

@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Jan 5, 2023

You can test the changes from this Pull Request by:
  • Clicking here or scanning the QR code below to access App Center
  • Then installing the build number pr8560-42d22b0 on your iPhone

If you need access to App Center, please ask a maintainer to add you.

ealeksandrov
ealeksandrov approved these changes Jan 6, 2023
View reviewed changes
Copy link
Contributor

@ealeksandrov ealeksandrov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@Ecarrion Ecarrion merged commit 2c44962 into trunk Jan 6, 2023
@Ecarrion Ecarrion deleted the issue/refactor-results-controller branch January 6, 2023 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@ealeksandrov ealeksandrov ealeksandrov approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

feature: variation list Related to the variations list for variable products.

Projects

None yet

Milestone

11.8

Development

Successfully merging this pull request may close these issues.

4 participants

@Ecarrion @wpmobilebot @ealeksandrov